Ticket #11241 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Theta series of degree 2 uses "int" instead of "ZZ" for coefficients

Reported by: tornaria Owned by: justin
Priority: major Milestone: sage-4.7.1
Component: quadratic forms Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Jonathan Hanke
Authors: Gonzalo Tornaría Merged in: sage-4.7.1.alpha0
Dependencies: Stopgaps:

Description 

sage: Q = QuadraticForm(ZZ, 2, [1,1,1])
sage: F = Q.theta_series_degree_2(20)  
sage: map(type, F.values())            
[<type 'sage.rings.integer.Integer'>, <type 'int'>, <type 'int'>, <type 'int'>, <type 'int'>, <type 'int'>, <type 'sage.rings.integer.Integer'>, <type 'int'>]

For consistency, all the returned coefficients should be in ZZ.

Attachments

trac_11241.patch Download (1.1 KB) - added by tornaria 2 years ago.
Fix theta series coefficients to be in ZZ
11241.patch Download (1.2 KB) - added by jdemeyer 2 years ago.
Fixed patch format, apply only this

Change History

Changed 2 years ago by tornaria

Fix theta series coefficients to be in ZZ

comment:1 Changed 2 years ago by tornaria

  • Status changed from new to needs_review

comment:2 Changed 2 years ago by jonhanke

  • Status changed from needs_review to positive_review

This is a cosmetic change, to give consistency to the output. Looks good. =)

comment:3 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to needs_work

There should not be an empty line at the beginning of the commit message.

comment:4 Changed 2 years ago by jdemeyer

  • Reviewers set to Jonathan Hanke
  • Authors set to Gonzalo Tornaría

Changed 2 years ago by jdemeyer

Fixed patch format, apply only this

comment:5 Changed 2 years ago by jdemeyer

  • Status changed from needs_work to closed
  • Resolution set to fixed
  • Merged in set to sage-4.7.1.alpha0
Note: See TracTickets for help on using tickets.