Ticket #1124 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

[with patch] ModularSymbol.complement crashes on full subspaces

Reported by: syazdani Owned by: was
Priority: major Milestone: sage-2.8.13
Component: modular forms Keywords: zero_subspace
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

Here is a bug in modular symbols code: 

sage: M=ModularSymbols(11,2,1)
sage: M.complement()
---------------------------------------------------------------------------
<type 'exceptions.AttributeError'>        Traceback (most recent call last)

/net/mathserv/1/home/syazdani/research/programs/<ipython console> in <module>()

/home/syazdani/sage/local/lib/python2.5/site-packages/sage/modular/hecke/ambient_module.py in complement(self)
     96         Return the largest Hecke-stable complement of this space.
     97         """
---> 98         return self.zero_subspace()
     99
    100     def decomposition_matrix(self):

<type 'exceptions.AttributeError'>: 'ModularSymbolsAmbient_wt2_g0' object has no attribute 'zero_subspace'

The problem is that zero_subspace is not implemented. Although zero_submodule is. One possible fix is to change self.zero_subspace to self.zero_submodule(). That's the included patch.

Attachments

zero_submodule Download (715 bytes) - added by syazdani 6 years ago.
trivial patch
doctest Download (1.4 KB) - added by syazdani 6 years ago.
Added doctest for complement. Both patches should be applied.

Change History

Changed 6 years ago by syazdani

trivial patch

comment:1 Changed 6 years ago by syazdani

[with patch]

comment:2 Changed 6 years ago by mabshoff

  • Summary changed from ModularSymbol.complement crashes on full subspaces to [with patch] ModularSymbol.complement crashes on full subspaces
  • Milestone set to sage-2.9

comment:3 Changed 6 years ago by mabshoff

  • Priority changed from trivial to major

Changed 6 years ago by syazdani

Added doctest for complement. Both patches should be applied.

comment:4 Changed 6 years ago by mabshoff

  • Milestone changed from sage-2.9 to sage-2.8.13

comment:5 Changed 6 years ago by was

"I have reviewed this patch and it agree with it."

comment:6 Changed 6 years ago by mabshoff

  • Status changed from new to closed
  • Resolution set to fixed

Merged in 2.8.13.alpha0.

Note: See TracTickets for help on using tickets.