Ticket #11219 (closed enhancement: fixed)

Opened 2 years ago

Last modified 3 months ago

document "%edit" in the tutorial

Reported by: jhpalmieri Owned by: mvngu
Priority: minor Milestone: sage-4.7
Component: documentation Keywords:
Cc: kcrisman Work issues:
Report Upstream: N/A Reviewers: John Cremona
Authors: John Palmieri Merged in: sage-4.7.rc0
Dependencies: Stopgaps:

Description (last modified by jhpalmieri) (diff)

The attached patch adds documentation for the %edit command in the Sage tutorial.

Apply trac_11219-ipython-edit.v2.patch Download.

Attachments

trac_11219-ipython-edit.patch Download (5.4 KB) - added by jhpalmieri 2 years ago.
trac_11219-ipython-edit.v2.patch Download (5.8 KB) - added by jhpalmieri 2 years ago.
apply only this patch
trac_11219-ipython-edit.delta.patch Download (863 bytes) - added by jhpalmieri 2 years ago.
difference between versions 1 and 2, for reference only

Change History

Changed 2 years ago by jhpalmieri

comment:1 Changed 2 years ago by jhpalmieri

  • Status changed from new to needs_review

comment:2 Changed 2 years ago by jhpalmieri

This is related to #7586, by the way.

comment:3 Changed 2 years ago by cremona

  • Status changed from needs_review to positive_review

The patch applies and builds fine. I learned a lot from reading the tutorial after testing that!

One thing does not work as advertised, I think: using logstart. I could not load unless I gave the logfile a suffix such as .sage or .py, note that the stored commands are preparsed before being stored. But when the file is loaded in another session I do not see this 

Loading log file <setup> one line at a time...
    Finished replaying log file <setup>

but rather this 

sage: load "setup.py"
Activating auto-logging. Current session state plus future input saved.
Filename       : setup.py
Mode           : backup
Output logging : False
Raw input log  : False
Timestamping   : False
State          : active

which does load the stuff *but also overwrites the file setup.py*!!!

So I'm giving this a positive review but want the other thing fixed before we forget all about it.

comment:4 Changed 2 years ago by jhpalmieri

  • Cc kcrisman added
  • Reviewers set to John Cremona
  • Status changed from positive_review to needs_info

In response to kcrisman's comment on sage-devel, I added a little bit about commands run in the background not being preparsed. Could you do another review on that? I'm posting a new patch ("...v2.patch") and another patch showing the difference, for easy reference.

Changed 2 years ago by jhpalmieri

apply only this patch

Changed 2 years ago by jhpalmieri

difference between versions 1 and 2, for reference only

comment:5 Changed 2 years ago by jhpalmieri

  • Status changed from needs_info to needs_review
  • Description modified (diff)

comment:6 Changed 2 years ago by cremona

  • Status changed from needs_review to positive_review

comment:7 Changed 2 years ago by jdemeyer

  • Milestone changed from sage-4.7.1 to sage-4.7

Looks safe enough for sage-4.7-rc0.

comment:8 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.7.rc0

comment:9 Changed 3 months ago by kcrisman

This never made it into the translations of the tutorial - German, French, or Russian. I don't know if they existed at the time in any case, but I've opened #14051 for this. I don't know if the newer translations not yet in I reference their have this stuff or not.

Note: See TracTickets for help on using tickets.