Ticket #11100 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

Increase default timeout of test_executable() to 50 seconds

Reported by: jdemeyer Owned by: mvngu
Priority: major Milestone: sage-4.7
Component: doctest coverage Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Volker Braun
Authors: Jeroen Demeyer Merged in: sage-4.7.alpha4
Dependencies: Stopgaps:

Description


Attachments

11100_test_executable.patch Download (2.8 KB) - added by jdemeyer 2 years ago.

Change History

comment:1 Changed 2 years ago by jdemeyer

  • Status changed from new to needs_review

Changed 2 years ago by jdemeyer

comment:2 Changed 2 years ago by vbraun

  • Status changed from needs_review to positive_review
  • Reviewers set to Volker Braun

Increasing it to 50 seconds is fine with me; But I doubt it that its sufficient on some NFS-connected machines where Sage startup can take forever. The default for doctests to time out is 360 seconds according to http://www.sagemath.org/doc/installation/source.html

But either way is better than 10 seconds.

comment:3 Changed 2 years ago by jdemeyer

360 is for a whole file I believe, while the 50 seconds is for one test. So increasing the timeout for test_executable() much more will not help because you will run into the whole-file timeout anyway.

comment:4 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.7.alpha4
Note: See TracTickets for help on using tickets.