Ticket #1106 (closed enhancement: fixed)

Opened 6 years ago

Last modified 5 years ago

[with patch, positive review] speed up dense matrix comparison

Reported by: malb Owned by: mhansen
Priority: major Milestone: sage-2.9.1
Component: linear algebra Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

The general implementation right now is: 

cdef int _cmp_c_impl(self, Element right) except -2:
    return cmp(self._list(), right._list())

which has a huge memory overhead. This should be optimised. Also, Matrix_modn_dense should have a faster special cmp method.

Attachments

1106.patch Download (1.3 KB) - added by mhansen 5 years ago.

Change History

comment:1 Changed 5 years ago by mabshoff

  • Milestone changed from sage-2.10 to sage-2.9.1

Changed 5 years ago by mhansen

comment:2 Changed 5 years ago by mhansen

  • Owner changed from was to mhansen
  • Status changed from new to assigned
  • Summary changed from speed up dense matrix comparison to [with patch] speed up dense matrix comparison

comment:3 Changed 5 years ago by rlm

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Summary changed from [with patch] speed up dense matrix comparison to [with patch, positive review] speed up dense matrix comparison

merged in 2.9.1 rc0

Note: See TracTickets for help on using tickets.