Ticket #10965 (closed defect: fixed)

Opened 2 years ago

Last modified 17 months ago

Fix trivial problems in plot/polygon

Reported by: kcrisman Owned by: jason, was
Priority: trivial Milestone: sage-4.8
Component: graphics Keywords: beginner sd35.5
Cc: Work issues:
Report Upstream: N/A Reviewers: Karl-Dieter Crisman
Authors: Peter Story, Kenneth Smith Merged in: sage-4.8.rc0
Dependencies: Stopgaps:

Description

For instance, 

Note this should normally be used indirectly via circle:

sage: from sage.plot.polygon import Polygon

circle?

Might as well also get more interpage hyperlinks while we're at it.

Attachments

trac_10965_circleFix.patch Download (1.3 KB) - added by peter.story 17 months ago.
Fixed extra line breaks.

Change History

comment:1 Changed 2 years ago by kcrisman

  • Keywords beginner added

comment:2 Changed 17 months ago by peter.story

  • Keywords sd35.5 added
  • Status changed from new to needs_review
  • Milestone set to sage-5.0
  • Authors set to Peter Story, Kenny Smith

comment:3 Changed 17 months ago by kcrisman

  • Status changed from needs_review to needs_work
  • Reviewers set to Karl-Dieter Crisman

Needs work, because of the blank lines in __getitem__.

comment:4 follow-up: ↓ 8 Changed 17 months ago by kcrisman

We try to keep lines short (more or less 80 characters) in documentation so they can be read nicely in terminals. So you should put 

or :func:`~sage.plot.plot3d.shapes2.polygon3d`

on a new line.

Also, you'll need a period at the end of the sentence at the beginning.

Otherwise seems like it should work fine!

Changed 17 months ago by peter.story

Fixed extra line breaks.

comment:5 Changed 17 months ago by peter.story

  • Status changed from needs_work to needs_review
  • Authors changed from Peter Story, Kenny Smith to Peter Story

Deleted extra newlines and added periods, as requested by 'kcrisman'.

comment:6 Changed 17 months ago by kcrisman

  • Status changed from needs_review to positive_review

Looks good.

comment:7 Changed 17 months ago by peter.story

  • Authors changed from Peter Story to Peter Story, Kenny Smith

comment:8 in reply to: ↑ 4 Changed 17 months ago by kini

Replying to kcrisman:

We try to keep lines short (more or less 80 characters) in documentation so they can be read nicely in terminals.

 PEP 8 suggests 72 characters for documentation, 79 for code (and presumably doctests).

comment:9 Changed 17 months ago by jdemeyer

  • Milestone changed from sage-5.0 to sage-4.8

comment:10 Changed 17 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.8.rc0

comment:11 Changed 17 months ago by ksmith

  • Authors changed from Peter Story, Kenny Smith to Peter Story, Kenneth Smith
Note: See TracTickets for help on using tickets.