Ticket #10827 (needs_work enhancement)

Opened 2 years ago

Last modified 16 months ago

Make cython support SAGE_SPKG_INSTALL_DOCS

Reported by: jason Owned by: tbd
Priority: major Milestone: sage-5.10
Component: packages: standard Keywords: sd32
Cc: Work issues:
Report Upstream: N/A Reviewers: David Kirkby
Authors: Jason Grout, John Palmieri Merged in:
Dependencies: Stopgaps:

Description (last modified by jhpalmieri) (diff)

This ticket implements #10823 for cython. New spkg at

 http://sage.math.washington.edu/home/palmieri/SPKG/cython-0.14.1.p2.spkg

Depends on #10493, #11197.

Attachments

10827.patch Download (1.3 KB) - added by jason 2 years ago.
FYI Only---already applied to spkg.
trac_10827-cython-spkg.patch Download (1.6 KB) - added by jhpalmieri 2 years ago.
for reference only; do not apply

Change History

comment:1 Changed 2 years ago by jason

  • Status changed from new to needs_review

comment:2 Changed 2 years ago by drkirkby

  • Status changed from needs_review to needs_work
  • Reviewers set to David Kirkby

See comments on #10828

comment:3 Changed 2 years ago by jason

Yes, this was done before #10828 was finalized. I'll post a new spkg.

Changed 2 years ago by jason

FYI Only---already applied to spkg.

comment:4 Changed 2 years ago by jason

  • Status changed from needs_work to needs_review
  • Description modified (diff)

New spkg up; see the new URL in the description.

comment:5 Changed 2 years ago by jason

  • Description modified (diff)

comment:6 Changed 2 years ago by drkirkby

  • Status changed from needs_review to needs_info

See my comments on #10828 I'm not saying this needs work, as it might not do, but if its anything like the matplotlib case, a lot of unnecessary files get copied.

We should clarify this before marking this for review.

Dave

comment:7 Changed 2 years ago by jason

  • Status changed from needs_info to needs_review

The cython docs that are copied contain just the standalone built files, not the full doc source directory.

comment:8 Changed 2 years ago by drkirkby

  • Status changed from needs_review to positive_review

That's ok then

comment:9 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.7.alpha1

comment:10 Changed 2 years ago by jdemeyer

  • Status changed from closed to new
  • Resolution fixed deleted
  • Merged in sage-4.7.alpha1 deleted

Cython doesn't build from scratch using SAGE_SPKG_INSTALL_DOCS, see also #10826.

comment:11 Changed 2 years ago by jdemeyer

  • Status changed from new to needs_work

comment:12 Changed 2 years ago by jason

See #11197 for building docs after sage is built.

comment:13 Changed 2 years ago by jason

See the bottom of #11197 for some other things that need to be done: add doc/ to .hgignore, and delete SPKG.txt.orig.

comment:14 Changed 2 years ago by jhpalmieri

  • Status changed from needs_work to needs_review
  • Description modified (diff)
  • Authors changed from Jason Grout to Jason Grout, John Palmieri

Here's a new spkg, based strongly on Jason's old one. I'm attaching the patch for reference.

Changed 2 years ago by jhpalmieri

for reference only; do not apply

comment:15 Changed 21 months ago by was

  • Keywords sd32 added

comment:16 Changed 16 months ago by kcrisman

  • Status changed from needs_review to needs_work

In the meantime Cython is version 0.15.1.

comment:17 Changed 16 months ago by kcrisman

I think we're also using different syntax for checking if SAGE_LOCAL is defined now.

Note: See TracTickets for help on using tickets.