Ticket #10819 (needs_work enhancement)
implementation of the cluster complex
| Reported by: | stumpc5 | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.10 |
| Component: | combinatorics | Keywords: | cluster complex |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | |
| Authors: | Christian Stump | Merged in: | |
| Dependencies: | #11010 | Stopgaps: |
Description (last modified by stumpc5) (diff)
The patch contains an implementation of the cluster complex for finite types.
sage: ClusterComplex(['A',3]) Cluster complex of type ['A', 3] with 9 vertices and 14 facets
The implementation depends on its realization as a subword complex.
Attachments
Change History
comment:2 Changed 2 years ago by stumpc5
- Status changed from new to needs_review
- Dependencies set to 10538,
- Description modified (diff)
comment:3 Changed 2 years ago by chapoton
- Owner sage-combinat deleted
Apply trac_10819-cluster_complex-cs.patch
comment:5 follow-up: ↓ 6 Changed 2 years ago by chapoton
Hi,
1) here also, the header is not correct, you should add ticket number #10819.
2) this seems to be a real error, which appears several times :
AttributeError?: 'sage.matrix.matrix_integer_sparse.Matrix_integer_sparse' object has no attribute 'is_skew_symmetrizable'
comment:6 in reply to: ↑ 5 Changed 2 years ago by stumpc5
Replying to chapoton:
1) here also, the header is not correct, you should add ticket number #10819.
I fixed it -- now I think I know what (not why) to do in order to pass the buildbot. Thanks!
2) this seems to be a real error, which appears several times :
There was one dependency missing, see #10298. This is like only knowing one linear extension of the ordering given by the dependencies -- so getting the dependencies is really try and error...
comment:8 follow-up: ↓ 9 Changed 20 months ago by chapoton
- Status changed from needs_review to needs_work
Hello Christian. Here are two things that need to be corrected :
1) type A_n is in n+3 sided polygon
2) formatting of doc is not correct in cartan_type
comment:9 in reply to: ↑ 8 Changed 20 months ago by stumpc5
Replying to chapoton:
I really appreciate that you do some progress on these patches, thanks!
I think I will reimplement this patch using subword complexes rather than the cluster implementation. This will be much faster, and I don't expect that the cluster package will become part of main sage soon (see the dependency above). On the other hand, the subword complexes depend on my new implementation of finite reflection groups (#11187) which depends on the implementation of the universal cyclotomic field (#8327), so it will also be unlikely that it will get positively reviewed soon (and I see that all of them have rejects in the newest versions, so it will be an even longer way).
1) type A_n is in n+3 sided polygon 2) formatting of doc is not correct in cartan_type
I will update the patch fixing these issues.
Best, Christian
comment:10 Changed 20 months ago by stumpc5
- Status changed from needs_work to needs_review
- Description modified (diff)
I fixed the two issues suggested by Frederic - what I do not like now is that the vertices are not positive roots anymore, but on the other hand the implementation is now valid for all finite Coxeter groups and also the multi-cluster complex can be constructed.
comment:11 follow-up: ↓ 12 Changed 14 months ago by davidloeffler
- Status changed from needs_review to needs_work
Applying this and its dependencies to 5.0.beta11 results in a Sage install that won't start up, and hence fails every doctest in the library -- see patchbot logs.
comment:12 in reply to: ↑ 11 Changed 14 months ago by stumpc5
Replying to davidloeffler:
Applying this and its dependencies to 5.0.beta11 results in a Sage install that won't start up, and hence fails every doctest in the library -- see patchbot logs.
Thanks for looking at it - for now, I would prefer if we postpone this patch, since I want to make some further improvements here.
Best, Christian


some comments :
there is a typo in "facet" at the beginning.
The examples are wrong, because they call "associahedron" which has nothing to do with the simplicial complex.
There is a "tba" in the examples section, that should be removed or replaced by a true example
You should include serious tests, like the computation of the homology of an example.