Ticket #10780 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

fix exception-eating bug in sagenb/misc/misc.py

Reported by: kini Owned by: jason, mpatel, was
Priority: major Milestone: sage-4.7
Component: notebook Keywords: notebook, exception handling
Cc: roed@… Work issues:
Report Upstream: N/A Reviewers: Volker Braun
Authors: David Roe Merged in: sage-4.7.alpha1
Dependencies: Stopgaps:

Description (last modified by kini) (diff)

See  this sage-devel post.

Apply to sagenb

Attachments

trac_10780-regurgitate-exception.patch Download (611 bytes) - added by kini 2 years ago.

Change History

comment:1 Changed 2 years ago by kini

  • Cc roed@… added
  • Status changed from new to needs_review
  • Authors set to David Roe

Here is a patch adding the three lines of code David Roe gave in his sage-devel post. I've attributed the patch to him - hopefully that was the right thing to do?

comment:2 Changed 2 years ago by roed

It's fine with me, but someone else should probably review it.

comment:3 Changed 2 years ago by kini

  • Description modified (diff)

Apply to sagenb

(hopefully patchbot can read the above someday)

comment:4 Changed 2 years ago by vbraun

  • Status changed from needs_review to positive_review

Looks good to me.

comment:5 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to needs_work
  • Reviewers set to Volker Braun

Edit the commit message of the patch (use hg qrefresh -e for that) such that the ticket number appears on the first line.

Changed 2 years ago by kini

comment:6 Changed 2 years ago by kini

  • Status changed from needs_work to needs_review

Sorry about that. I'll be more careful in the future.

comment:7 Changed 2 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:8 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.7.alpha1
Note: See TracTickets for help on using tickets.