Ticket #10751 (closed defect: fixed)
Upgrading 4.5.3 -> 4.6.2.alpha4 fails
|Reported by:||jdemeyer||Owned by:||GeorgSWeber|
|Component:||build||Keywords:||cython upgrade dependencies|
|Report Upstream:||N/A||Reviewers:||Jeroen Demeyer|
|Authors:||Volker Braun||Merged in:||sage-4.7.alpha1|
Description (last modified by vbraun) (diff)
This is a problem I discovered when upgrading from sage-4.5.3 to a candidate 4.6.2.alpha4. Probably, the problem has existed for a while, it just "surfaced" or got noticed now.
The problem is that the file sage/algebras/quatalg/quaternion_algebra_element.cpp is not recreated from the corresponding .pyx file when upgrading. This then causes a compile error.
The file sage/algebras/quatalg/quaternion_algebra_element.pyx includes (using Cython's include statement) sage/ext/gmp.pxi and the latter file was changed some Sage versions ago.
The following happens:
$ ./sage -b ---------------------------------------------------------- sage: Building and installing modified Sage library files. Installing c_lib scons: `install' is up to date. =================== setup.py ======================== Updating Cython code.... Time to execute 0 commands: 1.31130218506e-05 seconds Finished compiling Cython code (time = 0.0120220184326 seconds) running install running build running build_py running build_ext building 'sage.algebras.quatalg.quaternion_algebra_element' extension building 'sage.calculus.riemann' extension [...] building 'sage.symbolic.pynac' extension building 'sage.symbolic.ring' extension gcc -fno-strict-aliasing -g -O2 -DNDEBUG -g -O3 -Wall -Wstrict-prototypes -fPIC -I/mnt/usb1/scratch/jdemeyer/sage-4.5.3-4.6.2.alpha4/local/include/FLINT/ -I/mnt/usb1/scratch/jdemeyer/sage-4.5.3-4.6.2.alpha4/local/include -I/mnt/usb1/scratch/jdemeyer/sage-4.5.3-4.6.2.alpha4/local/include/csage -I/mnt/usb1/scratch/jdemeyer/sage-4.5.3-4.6.2.alpha4/devel/sage/sage/ext -I/mnt/usb1/scratch/jdemeyer/sage-4.5.3-4.6.2.alpha4/local/include/python2.6 -c sage/algebras/quatalg/quaternion_algebra_element.cpp -o build/temp.linux-x86_64-2.6/sage/algebras/quatalg/quaternion_algebra_element.o -w [trouble...]
Depends on #10233
That is, first apply trac_10233_fix_cython_include_path.patch from the dependency and then trac_10751_fix.patch.
- Keywords dependencies added
- Status changed from new to needs_work
- Authors set to Volker Braun
- Status changed from needs_work to needs_review
- Description modified (diff)
comment:15 Changed 2 years ago by jdemeyer
- Status changed from needs_review to positive_review
- Reviewers set to Jeroen Demeyer