Ticket #1075 (closed defect: invalid)

Opened 6 years ago

Last modified 6 years ago

[with patch] sync'ing hashes for fraction fields and rings

Reported by: jbmohler Owned by: somebody
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: basic arithmetic Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description

The attached patch provides a custom hash function for fraction field elements so that fractions with a denominator of 1 hash the same as the hash of the numerator as an element in the ring. A charming side effect is that hash is *much* faster now for fraction field elements of MPoly's over QQ.

This fixes some bugs (IMO) in the subs method of ParentWithGens? when passing a dictionary.

I don't think there is any problems with hash's changing from one version to the next -- I guess there might be something I'm missing here.

Attachments

subst_hash.hg Download (1.2 KB) - added by jbmohler 6 years ago.

Change History

Changed 6 years ago by jbmohler

comment:1 Changed 6 years ago by jbmohler

  • Milestone changed from sage-2.9 to sage-2.8.12

comment:2 Changed 6 years ago by jbmohler

  • Status changed from new to closed
  • Resolution set to invalid

I'm closing this because the patch I'm going to attached to #1181 is much better and much broader.

comment:3 Changed 6 years ago by mabshoff

  • Milestone changed from sage-2.10 to sage-duplicate/invalid
Note: See TracTickets for help on using tickets.