Ticket #10737 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

Extended echelon form of a matrix

Reported by: rbeezer Owned by: jason, was
Priority: minor Milestone: sage-4.7
Component: linear algebra Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: John Palmieri
Authors: Rob Beezer Merged in: sage-4.7.alpha4
Dependencies: Stopgaps:

Description (last modified by jhpalmieri) (diff)

A convenience for teaching linear algebra. Doctests (at least) depend on #10543, which was discovered in the course of building this.

Depends: #10543


Apply trac_10737-extended-echelon-form.patch Download and trac_10737-referee-doc.patch Download.

Attachments

trac_10737-extended-echelon-form.patch Download (9.1 KB) - added by rbeezer 2 years ago.
trac_10737-referee-doc.patch Download (980 bytes) - added by jhpalmieri 2 years ago.
apply on top of other patch

Change History

Changed 2 years ago by rbeezer

comment:1 Changed 2 years ago by rbeezer

  • Status changed from new to needs_review
  • Authors set to Rob Beezer

Changed 2 years ago by jhpalmieri

apply on top of other patch

comment:2 follow-up: ↓ 3 Changed 2 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Description modified (diff)

The main patch looks good to me: positive review. All tests pass, and I also tested on things like 0x0 matrices. I've added a small patch rewording one sentence in the documentation; this requires review.

comment:3 in reply to: ↑ 2 Changed 2 years ago by rbeezer

Replying to jhpalmieri:

The main patch looks good to me: positive review. All tests pass, and I also tested on things like 0x0 matrices. I've added a small patch rewording one sentence in the documentation; this requires review.

Rewording looks great - thanks.

comment:4 Changed 2 years ago by jhpalmieri

  • Status changed from needs_review to positive_review

comment:5 Changed 2 years ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.7.alpha4
Note: See TracTickets for help on using tickets.