Ticket #10666 (closed defect: fixed)
document the SAGE_ATLAS_ARCH environment variable
| Reported by: | ddrake | Owned by: | mvngu |
|---|---|---|---|
| Priority: | major | Milestone: | sage-4.7.2 |
| Component: | documentation | Keywords: | |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | Dan Drake |
| Authors: | Volker Braun | Merged in: | sage-4.7.2.alpha0 |
| Dependencies: | #10226 | Stopgaps: |
Description (last modified by jdemeyer) (diff)
At #10226, Volker Braun rewrote the installation scripts for ATLAS in pure Python, and introduced a new environment variable: SAGE_ATLAS_ARCH. This should be documented in the installation guide: http://sagemath.org/doc/installation/source.html#environment-variables
Also, the SAGE_ATLAS_LIB now only has to point to the directory contaning the libraries.
Apply trac_10666_document_SAGE_ATLAS_ARCH.patch, trac_10666_document_SAGE_ATLAS_LIB.patch.
See also #10226 (Rewrite ATLAS spkg-install).
Attachments
-
10666.patch
(1.7 KB) -
added by ddrake 2 years ago.
-
trac_10666_document_SAGE_ATLAS_ARCH.2.patch
(2.4 KB) -
added by vbraun 2 years ago.
- Updated patch
-
trac_10666_document_SAGE_ATLAS_LIB.patch
(1.4 KB) -
added by vbraun 2 years ago.
- Updated patch
-
trac_10666_document_SAGE_ATLAS_ARCH.patch
(2.4 KB) -
added by vbraun 2 years ago.
- Updated patch
Change History
comment:2 follow-up: ↓ 3 Changed 2 years ago by vbraun
- Authors set to Dan Drake, Volker Braun
Oops, I hadn't noticed that you posted a patch already... My version is essentially the same but a bit more verbose.
comment:3 in reply to: ↑ 2 Changed 2 years ago by ddrake
- Status changed from needs_review to positive_review
- Reviewers set to Dan Drake
- Authors changed from Dan Drake, Volker Braun to Volker Braun
Replying to vbraun:
Oops, I hadn't noticed that you posted a patch already... My version is essentially the same but a bit more verbose.
Your version is a little more useful to someone reading the installation guide, trying to figure out what to do. Let's use yours.
comment:4 Changed 2 years ago by ddrake
Release manager: apply only attachment:trac_10666_document_SAGE_ATLAS_ARCH.patch after ticket #10226 is merged.
comment:6 Changed 2 years ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-4.7.alpha1
comment:7 Changed 2 years ago by jdemeyer
- Status changed from closed to new
- Resolution fixed deleted
- Merged in sage-4.7.alpha1 deleted
comment:9 Changed 2 years ago by jdemeyer
- Status changed from needs_review to positive_review
This will get merged together with #10226.
comment:10 Changed 2 years ago by vbraun
- Status changed from positive_review to needs_work
- Description modified (diff)
comment:11 follow-up: ↓ 12 Changed 2 years ago by vbraun
- Status changed from needs_work to needs_review
The SAGE_ATLAS_LIB patch still needs review, should be uncontroversial. In particular, backward compatibility is maintained.
comment:12 in reply to: ↑ 11 Changed 2 years ago by ddrake
- Status changed from needs_review to needs_work
Replying to vbraun:
The SAGE_ATLAS_LIB patch still needs review, should be uncontroversial. In particular, backward compatibility is maintained.
Looks good, but one tiny grammar note: you need "It should contain" not "It should containing". That's such a tiny change that you can switch this to positive review once you fix it.
comment:13 Changed 2 years ago by vbraun
- Status changed from needs_work to positive_review
Thanks for proof reading!
Changed 2 years ago by vbraun
-
attachment
trac_10666_document_SAGE_ATLAS_ARCH.2.patch
added
Updated patch
Changed 2 years ago by vbraun
-
attachment
trac_10666_document_SAGE_ATLAS_LIB.patch
added
Updated patch
Changed 2 years ago by vbraun
-
attachment
trac_10666_document_SAGE_ATLAS_ARCH.patch
added
Updated patch
comment:16 Changed 2 years ago by vbraun
Rediffed to apply cleanly to Sage-4.7.alpha4
comment:19 Changed 2 years ago by jdemeyer
- Merged in sage-4.7.1.alpha3 deleted
- Milestone changed from sage-4.7.1 to sage-pending
comment:20 Changed 22 months ago by jdemeyer
- Status changed from positive_review to closed
- Resolution set to fixed
- Merged in set to sage-4.7.2.alpha0
