Ticket #1057 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

[with patch] Order elements do not have Z as a (proper) basering

Reported by: robertwb Owned by: mabshoff
Priority: critical Milestone: sage-2.8.12
Component: number theory Keywords:
Cc: Work issues:
Report Upstream: Reviewers:
Authors: Merged in:
Dependencies: Stopgaps:

Description 

sage: sage: K.<a> = NumberField(x^2 - 5)
sage: sage: B = K.maximal_order().basis();
sage: B[1].parent().base_ring() # this is bad
Rational Field
sage: B[1].parent().base()
Integer Ring

Also, _rmul_, etc needs to be re-implemented.

Attachments

1057-fix-order-basering.hg Download (1.9 KB) - added by robertwb 6 years ago.

Change History

comment:1 Changed 6 years ago by robertwb

  • Owner changed from was to robertwb

comment:2 Changed 6 years ago by mabshoff

  • Milestone set to sage-2.8.11

Changed 6 years ago by robertwb

comment:3 Changed 6 years ago by robertwb

  • Summary changed from Order elements do not have Z as a (proper) basering to [with patch] Order elements do not have Z as a (proper) basering

Orders now have correct baserings.

Whoever implemented the _base attribute might want to look at how it overrides the (cdef) ParentBase?._base attribute, and the implications that might have.

This patch makes patch #1044 obsolete.

comment:4 Changed 6 years ago by mabshoff

  • Owner changed from robertwb to mabshoff
  • Status changed from new to assigned

applied to 2.8.11.rc2 after reverting #1044.

comment:5 Changed 6 years ago by was

  • Milestone changed from sage-2.9 to sage-2.8.12

This is already fixed and in sage-2.8.11.

comment:6 Changed 6 years ago by was

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.