Ticket #10292 (closed defect: fixed)

Opened 3 years ago

Last modified 18 months ago

padics, precision, list() and printing

Reported by: roed Owned by: roed
Priority: minor Milestone: sage-4.8
Component: padics Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: Johan Bosman
Authors: David Roe Merged in: sage-4.8.alpha4
Dependencies: Stopgaps:

Description (last modified by johanbosman) (diff) 

sage: E = EllipticCurve('37a')
sage: R = E.padic_regulator(7)
sage: len(R.list())
37
sage: s = str(R)
sage: len(R.list())
19

Similarly: 

sage: E = EllipticCurve('37a')
sage: R = E.padic_regulator(7)
sage: len(R.list())
37
sage: R.precision_absolute()
20
sage: len(R.list())
37
sage: R.precision_relative()
19
sage: len(R.list())
19

This is likely due to _normalize not getting called when necessary at object creation.

Apply:

  1. 10292.patch Download
  2. 10292_review.patch Download

to the sage repository.

Attachments

10292.patch Download (3.3 KB) - added by roed 19 months ago.
10292_review.patch Download (1.0 KB) - added by johanbosman 18 months ago.

Change History

Changed 19 months ago by roed

comment:1 Changed 19 months ago by roed

  • Status changed from new to needs_review

Changed 18 months ago by johanbosman

comment:2 Changed 18 months ago by johanbosman

  • Reviewers set to Johan Bosman
  • Description modified (diff)
  • Authors set to David Roe

I've uploaded a patch that fixes the docstring formatting. If you agree with this, this can be given a positive_review.

comment:3 Changed 18 months ago by roed

  • Status changed from needs_review to positive_review

Looks good to me. I should look over the Sphinx documentation to see when .. is advisable. The lack of :: was just an oversight.

comment:4 Changed 18 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-4.8.alpha4
Note: See TracTickets for help on using tickets.