Ticket #10290 (closed enhancement: fixed)
Upgrade Pygments to version 1.3.1
| Reported by: | jdemeyer | Owned by: | tbd |
|---|---|---|---|
| Priority: | blocker | Milestone: | sage-4.6.1 |
| Component: | packages: standard | Keywords: | pygments spkg |
| Cc: | Work issues: | ||
| Report Upstream: | N/A | Reviewers: | Minh Van Nguyen |
| Authors: | Jeroen Demeyer | Merged in: | sage-4.6.1.alpha2 |
| Dependencies: | Stopgaps: |
Description (last modified by jdemeyer) (diff)
Pygments is the syntax highlighter used by Sphinx to highlight the documentation. Currently, we ship version 0.11.1 of Pygments which has no Cython support, the latest upstream version does support Python. I think this is a good reason to upgrade Pygments.
New spkg: http://sage.math.washington.edu/home/jdemeyer/spkg/pygments-1.3.1.p0.spkg
See also #10118 (Sphinx upgrade)
Follow-up: #10324
Attachments
-
10290_cython_highlight.patch
(2.3 KB) -
added by jdemeyer 3 years ago.
- doc patch for Cython syntax highlighting
Change History
comment:2 Changed 3 years ago by jdemeyer
- Status changed from new to needs_work
- Description modified (diff)
- Authors set to Jeroen Demeyer
Changed 3 years ago by jdemeyer
-
attachment
10290_cython_highlight.patch
added
doc patch for Cython syntax highlighting
comment:3 Changed 3 years ago by jdemeyer
- Status changed from needs_work to needs_review
- Merged in set to sage-4.6.1.alpha2
comment:4 Changed 3 years ago by jdemeyer
- Priority changed from major to blocker
Making this a blocker because #10118 is also a blocker and these need to be merged together.
comment:6 Changed 3 years ago by mvngu
- Status changed from needs_review to positive_review
- Reviewers set to Minh Van Nguyen
The Sage documentation looks much more beautiful now, especially Cython code blocks that have been specially designated to use Cython code highlighting. I love the demonstration of how to highlight a Cython code block. I'm OK with the patch to Pygments 1.3.1; the patch is small enough to be easily understood.
