Ticket #10227 (needs_review defect)

Opened 3 years ago

Last modified 6 months ago

change_labels for sum species structure does not actually change the labels

Reported by: mhansen Owned by: hivert
Priority: major Milestone: sage-5.11
Component: combinatorics Keywords: species
Cc: sage-combinat Work issues:
Report Upstream: N/A Reviewers: Florent Hivert
Authors: Mike Hansen Merged in:
Dependencies: #5457, #5512, #13317 Stopgaps:

Description 

sage: X = species.SingletonSpecies()
sage: X2 = X+X
sage: X2.structures([1]).list()
[1, 1]
sage: s = X2.structures([1]).list()[0]
sage: s.labels()
[1]
sage: s.change_labels(["a"])
1

Attachments

trac_10227-species_fixes-mh.patch Download (21.7 KB) - added by mhansen 11 months ago.

Change History

comment:1 Changed 3 years ago by mhansen

  • Cc sage-combinat added
  • Status changed from new to needs_review
  • Milestone set to sage-4.6.2
  • Authors set to Mike Hansen

This patch does a couple of things:

  1. Fix the change_labels bug above.
  1. Add a left/right summand/factor method to sum and product species.
  1. Make the labels method return all of the labels rather than just the ones that appear. This is a backwards incompatible change, but I am pretty sure that there isn't really any code out there that depends on this.
  1. Add a labels_subset method to do what the old labels methods did for subsets.
  1. Add additional documentation to some of the classes.

comment:2 Changed 2 years ago by jdemeyer

  • Milestone changed from sage-4.6.2 to sage-4.7

comment:3 Changed 16 months ago by hivert

  • Owner changed from mhansen to hivert
  • Reviewers set to Florent Hivert

I'm assigning the ticket to myself to remember to review it.

comment:4 Changed 11 months ago by mhansen

Florent, if you have time, could you take a quick look at this. #5512 is waiting on it.5512 Thanks!

comment:5 Changed 11 months ago by mhansen

  • Dependencies set to #5512

I rebased trac_10227-species_fixes-mh.patch on #5512

Apply trac_10227-species_fixes-mh.patch

comment:6 Changed 11 months ago by mhansen

  • Dependencies changed from #5512 to #5512, #13317

Changed 11 months ago by mhansen

comment:7 Changed 11 months ago by mhansen

  • Dependencies changed from #5512, #13317 to #5457, #5512, #13317

comment:8 Changed 6 months ago by chapoton

  • Keywords species added
Note: See TracTickets for help on using tickets.