Ticket #10175 (closed enhancement: fixed)

Opened 3 years ago

Last modified 16 months ago

symmetric and exterior powers of characters

Reported by: vbraun Owned by: joyner
Priority: major Milestone: sage-5.0
Component: group theory Keywords:
Cc: Work issues:
Report Upstream: N/A Reviewers: David Roe
Authors: Volker Braun Merged in: sage-5.0.beta3
Dependencies: Stopgaps:

Description (last modified by jdemeyer) (diff)

The gap-functions for computing exterior and symmetric powers of characters are not exposed. This patch implements these.

Apply trac_10175_anti_symmetric_product_characters.patch Download

Attachments

trac_10175_anti_symmetric_product_characters.2.patch Download (19.0 KB) - added by vbraun 17 months ago.
Updated patch
trac_10175_anti_symmetric_product_characters.patch Download (20.7 KB) - added by vbraun 17 months ago.
Updated patch

Change History

comment:1 Changed 3 years ago by vbraun

  • Status changed from new to needs_review

Changed 17 months ago by vbraun

Updated patch

comment:2 Changed 17 months ago by vbraun

  • Description modified (diff)

Rediffed for sage-4.8.alpha4

comment:3 Changed 17 months ago by roed

  • Status changed from needs_review to needs_work
  • Reviewers set to David Roe

Just a couple comments:

  • You need to raise the NotImplementedError on line 281, and there are a couple other points in the file where this same mistake is made.
  • In the documentation of mul, you only allow multiplication by an integer. But you can in fact multiply by other scalars that coerce into Gap: number field elements for example.

Other than that, I'll run the tests once I build a new copy of Sage on sage.math and fly to Boston.

Changed 17 months ago by vbraun

Updated patch

comment:4 Changed 17 months ago by vbraun

  • Status changed from needs_work to needs_review

Fixed in the updated patch. Also, made sage -coverage happy.

comment:5 Changed 16 months ago by roed

  • Status changed from needs_review to positive_review

Looks good to me. Sorry for the delay.

comment:6 Changed 16 months ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 16 months ago by jdemeyer

  • Status changed from positive_review to closed
  • Resolution set to fixed
  • Merged in set to sage-5.0.beta3
Note: See TracTickets for help on using tickets.