Ticket #10106 (closed defect: fixed)
Change "export FC=foo" to "FC=foo ; export FC" and similar in scipy_sandbox
| Reported by: | drkirkby | Owned by: | GeorgSWeber |
|---|---|---|---|
| Priority: | blocker | Milestone: | sage-4.6 |
| Component: | build | Keywords: | |
| Cc: | mpatel, fbissey | Work issues: | |
| Report Upstream: | N/A | Reviewers: | Mitesh Patel |
| Authors: | David Kirkby | Merged in: | sage-4.6.alpha3 |
| Dependencies: | Stopgaps: |
Description
#10092 added 4 lines of code:
export FC="${SAGE_LOCAL}/bin/sage_fortran"
export F77="${SAGE_LOCAL}/bin/sage_fortran"
export F90="${SAGE_LOCAL}/bin/sage_fortran"
export F95="${SAGE_LOCAL}/bin/sage_fortran"
but using export and the variable name at the same time is not portable. For improved portability, which will work with any shell,
FC="${SAGE_LOCAL}/bin/sage_fortran"
export FC
F77="${SAGE_LOCAL}/bin/sage_fortran"
export F77
F90="${SAGE_LOCAL}/bin/sage_fortran"
export F90
F95="${SAGE_LOCAL}/bin/sage_fortran"
export F95
should work.
Attachments
Change History
Changed 3 years ago by drkirkby
-
attachment
10106-imporve-portability-of-exports.patch
added
Improved portability, so will work with virtually any shell
comment:3 Changed 3 years ago by drkirkby
- Status changed from new to needs_review
- Authors set to David Kirkby
The revised package may be found here. I've checked it on my OpenSolaris machine, but also on fulvia where it failed before:
Writing /home/drkirkby/fulvia/32/sage-4.5.2/local/lib/python2.6/site-packages/delaunay-0.0.0-py2.6.egg-info real 0m39.298s user 0m23.574s sys 0m3.721s Successfully installed scipy_sandbox-20071020.p7 Now cleaning up tmp files. rm: Cannot remove any directory in the path of the current working directory /home/drkirkby/fulvia/32/sage-4.5.2/spkg/build/scipy_sandbox-20071020.p7 Making Sage/Python scripts relocatable... Making script relocatable Finished installing scipy_sandbox-20071020.p7.spkg 32 drkirkby@fulvia:[~/fulvia/32/sage-4.5.2] $ uname -a SunOS fulvia 5.10 Generic_127128-11 i86pc i386 i86pc
comment:4 Changed 3 years ago by drkirkby
Oops, I forgot to post the link
http://boxen.math.washington.edu/home/kirkby/patches/scipy_sandbox-20071020.p7.spkg
Note: See
TracTickets for help on using
tickets.
