Changeset 8542:566052e39256

Timestamp:

12/02/07 01:30:12 (5 years ago)

Author:

Robert Bradshaw <robertwb@…>

Branch:

default

Message:

Copy D for quadratic field elements in _new

File:

• sage/rings/number_field/number_field_element_quadratic.pyx (modified) (13 diffs)

sage/rings/number_field/number_field_element_quadratic.pyx

@@ -56 +56 @@
 
 cdef class NumberFieldElement_quadratic(NumberFieldElement_absolute):
+
     def __init__(self, parent, f):
         """
@@ -155 +156 @@
                 mpz_set_ui(self.denom, 1)
         
+    cdef _new(self):
+        """
+        Quickly creates a new initialized NumberFieldElement with the
+        same parent as self.
+        """
+        cdef NumberFieldElement_quadratic x
+        x = <NumberFieldElement_quadratic>PY_NEW_SAME_TYPE(self)
+        x._parent = self._parent
+        x.D = self.D
+        return x
+
     cdef number_field(self):
         return self._parent
@@ -179 +191 @@
         mpz_set(x.b, self.b)
         mpz_set(x.denom, self.denom)
-        x.D = self.D
         return x
         
@@ -319 +330 @@
         cdef NumberFieldElement_quadratic res = <NumberFieldElement_quadratic>self._new()
         cdef mpz_t gcd, tmp
-        res.D = self.D
         if mpz_cmp(self.denom, other.denom) == 0:
             mpz_add(res.a, self.a, other.a)
@@ -366 +376 @@
         cdef NumberFieldElement_quadratic res = <NumberFieldElement_quadratic>self._new()
         cdef mpz_t gcd, tmp
-        res.D = self.D
         if mpz_cmp(self.denom, other.denom) == 0:
             mpz_sub(res.a, self.a, other.a)
@@ -408 +417 @@
         """
         cdef NumberFieldElement_quadratic res = <NumberFieldElement_quadratic>self._new()
-        res.D = self.D
         mpz_neg(res.a, self.a)
         mpz_neg(res.b, self.b)
@@ -439 +447 @@
         cdef NumberFieldElement_quadratic other = <NumberFieldElement_quadratic>other_m
         cdef NumberFieldElement_quadratic res = <NumberFieldElement_quadratic>self._new()
-        res.D = self.D
         cdef mpz_t tmp
         
@@ -482 +489 @@
         cdef Rational c =  <Rational>_c
         cdef NumberFieldElement_quadratic res = <NumberFieldElement_quadratic>self._new()
-        res.D = self.D
         mpz_mul(res.a, self.a, mpq_numref(c.value))
         mpz_mul(res.b, self.b, mpq_numref(c.value))
@@ -499 +505 @@
         cdef Rational c =  <Rational>_c
         cdef NumberFieldElement_quadratic res = <NumberFieldElement_quadratic>self._new()
-        res.D = self.D
         mpz_mul(res.a, self.a, mpq_numref(c.value))
         mpz_mul(res.b, self.b, mpq_numref(c.value))
@@ -543 +548 @@
         """
         cdef NumberFieldElement_quadratic res = <NumberFieldElement_quadratic>self._new()
-        res.D = self.D
         cdef mpz_t tmp, gcd
         mpz_init(tmp)
@@ -577 +581 @@
     cdef NumberFieldElement conjugate_c(self):
         cdef NumberFieldElement_quadratic res = <NumberFieldElement_quadratic>self._new()
-        res.D = self.D
         mpz_set(res.a, self.a)
         mpz_neg(res.b, self.b)
@@ -905 +908 @@
         cdef Integer c = <Integer>_c
         cdef NumberFieldElement_quadratic res = <NumberFieldElement_quadratic>self._new()
-        res.D = self.D
         mpz_mul(res.a, self.a, c.value)
         mpz_mul(res.b, self.b, c.value)
@@ -925 +927 @@
         cdef Integer c = <Integer>_c
         cdef NumberFieldElement_quadratic res = <NumberFieldElement_quadratic>self._new()
-        res.D = self.D
         mpz_mul(res.a, self.a, c.value)
         mpz_mul(res.b, self.b, c.value)