Changeset 7509:21545374e52d

Timestamp:

12/02/07 11:15:37 (5 years ago)

Author:

Craig Citro <craigcitro@…>

Branch:

default

Message:

Touch-ups to trac #1129 suggested by cwitty.

File:

• sage/rings/polynomial/polynomial_element.pyx (modified) (2 diffs)

sage/rings/polynomial/polynomial_element.pyx

@@ -1634 +1634 @@
             
         elif is_NumberField(R):
-            if (R.defining_polynomial().denominator() == 1) and \
-                   (self.denominator() == 1):
-                v = [ x._pari_("a") for x in self.list() ]
+            if (R.defining_polynomial().denominator() == 1):
+
+                if (self.leading_coefficient() == 1):
+                    unit = None
+                    v = [ x._pari_("a") for x in self.list() ]
+                else:
+                    unit = self.leading_coefficient()
+                    temp_f = self * 1/unit
+                    v = [ x._pari_("a") for x in temp_f.list() ]
                 f = pari(v).Polrev()
                 Rpari = R.pari_nf()
@@ -1644 +1650 @@
                     Rpari[6] = [ x("a") for x in Rpari[6] ]
                 G = list(Rpari.nffactor(f))
+                return self._factor_pari_helper(G, unit=unit)
 
             else: