Ticket #3654: sage-3654-deprecation.patch

a/sage/combinat/root_system/dynkin_diagram.py

@@ -77 +77 @@
-        Dynkin diagram of type ['A', 3]
-
-    """
-import warnings
-warnings.warn("dynkin_diagram is deprecated, use DynkinDiagram instead!", DeprecationWarning, stacklevel=2
+from sage.misc.misc import deprecation
+deprecation("dynkin_diagram is deprecated, use DynkinDiagram instead!"
-    return DynkinDiagram(t)
-
-

a/sage/misc/misc.py

@@ -1576 +1576 @@
-        False
-    """
-    return sage.server.support.EMBEDDED_MODE
+
+#################################################################
+# Deprecation
+#################################################################
+from warnings import warn
+
+def deprecation(message):
+    r"""
+    Issue a deprecation warning.
+
+    EXAMPLE:
+        sage: def foo():
+        ...    sage.misc.misc.deprecation("The function foo is replaced by bar.")
+        ...
+        sage: def my_function():
+        ...    foo()
+        ...
+        sage: my_function() # random: I don't know how to test the output.
+        doctest:1: DeprecationWarning: The function foo is replaced by bar.
+    """
+    # Stack level 3 to get the line number of the code which called
+    # the deprecated function which called this function.
+    warn(message, DeprecationWarning, stacklevel=3)

a/sage/rings/polynomial/polynomial_ring_constructor.py

@@ -311 +311 @@
-    return R
-
-def MPolynomialRing(*args, **kwds):
-import warnings
-warnings.warn("MPolynomialRing is deprecated, use PolynomialRing instead!", DeprecationWarning, stacklevel=2
+from sage.misc.misc import deprecation
+deprecation("MPolynomialRing is deprecated, use PolynomialRing instead!"
-    return PolynomialRing(*args, **kwds)
-
-MPolynomialRing.__doc__ = """