Ticket #3153: GF2X_sparse_poly_fix_random.patch

sage/misc/randstate.pyx

@@ -354 +354 @@
 every function that wants to use it; don't cache it globally or 
 in a class.  (Such caching would break \method{set_random_seed}).
 
+\item[NTL] If you are calling code in the NTL library that uses
+random numbers, call \method{set_seed_ntl} at the beginning of your
+function, like this:
+\begin{verbatim}
+from sage.misc.randstate import current_randstate
+...
+
+    current_randstate().set_seed_ntl(False)
+\end{verbatim}
+
+Fetch the current \class{randstate} with \code{current_randstate()} in 
+every function that wants to use it; don't cache it globally or 
+in a class.  (Such caching would break \method{set_random_seed}).
+
 \item[libc] If you are writing code that calls the libc function
 \code{random()}: don't!  The \code{random()} function does not give
 reproducible results across different operating systems, so we can't 
@@ -374 +388 @@
 from sage.misc.randstate import current_randstate
 ...
 
-    current_randstate().set_seed_libc()
+    current_randstate().set_seed_libc(False)
 \end{verbatim}
 
 Fetch the current \class{randstate} with \code{current_randstate()} in 

sage/rings/finite_field_ntl_gf2e.pyx

@@ -48 +48 @@
 from sage.libs.pari.gen import gen
 
 from sage.interfaces.gap import is_GapElement
+
+from sage.misc.randstate import current_randstate
 
 from finite_field_ext_pari import FiniteField_ext_pari
 from finite_field_element import FiniteField_ext_pariElement
@@ -161 +163 @@
             sage: k.modulus()
             x^1024 + x^19 + x^6 + x + 1
             sage: k.<a> = GF(2^17, modulus='random')
-            sage: k.modulus() # output random
-            x^17 + x^16 + x^15 + x^14 + x^12 + x^11 + x^7 + x^5 + 1
+            sage: k.modulus()
+            x^17 + x^16 + x^15 + x^10 + x^8 + x^6 + x^4 + x^3 + x^2 + x + 1
         """
         self._zero_element = self._new()
         GF2E_conv_long((<FiniteField_ntl_gf2eElement>self._zero_element).x,0)
@@ -200 +202 @@
 
         if modulus is None or modulus == "random":
             if modulus == "random":
+                current_randstate().set_seed_ntl(False)
                 GF2X_BuildSparseIrred(ntl_tmp, k)
                 GF2X_BuildRandomIrred(ntl_m, ntl_tmp)
             elif ConwayPolynomials().has_polynomial(p, k):